Updated certificate fingerprint and public key format #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jgrateron
commented
Apr 7, 2024
jgrateron
commented
|
Thanks, good work! I only have found some minor visual issues:
|
|
Add application preferences, PublicKeyFingerprintAlgorithm
|
kaikramer
reviewed
Apr 7, 2024
| @@ -77,29 +77,29 @@ DUpgradeCryptoStrength.jlDownloadPolicyInstructions.text = <html><b>1. Download | |||
| DUpgradeCryptoStrength.jlDropPolicyInstructions.text = <html><b>2. Install Unlimited Strength Jurisdiction Policy</b><br><br>Browse to the Unlimited Strength Jurisdiction Policy<br>ZIP or drop it onto the icon to the right. Finally press<br>the Upgrade button.</html> | |||
| DUpgradeCryptoStrength.jlUpgradeInstructions.text = <html>To upgrade cryptography to unlimited strength carry out the following<br>steps:</html> | |||
|
|
|||
| DViewCertificateFingerprint.Title = {0} Certificate Fingerprint | |||
| DViewCertificateFingerprint.Title = {0} Certificate FingerPrint | |||
There was a problem hiding this comment.
Ah, that was a misunderstanding, I meant the other way round (FingerPrint -> Fingerprint). Because fingerprint is a normal English word, there should be no need to capitalize the "p".
kaikramer
reviewed
Apr 7, 2024
| @@ -39,7 +40,8 @@ public class KsePreferences { | |||
| private CaCertsSettings caCertsSettings = new CaCertsSettings(); | |||
| private KeyGenerationSettings keyGenerationDefaults = new KeyGenerationSettings(); | |||
| private DigestType certificateFingerprintAlgorithm = DigestType.SHA1; | |||
| private PasswordQualityConfig passwordQualityConfig = new PasswordQualityConfig(false, false, 60); | |||
| private PublicKeyFingerprintAlgorithm publicKeyFingerprintAlgorithm = PublicKeyFingerprintAlgorithm.SKI_METHOD1; | |||
| private PasswordQualityConfig passwordQualityConfig = new PasswordQualityConfig(false, false, 60); | |||
There was a problem hiding this comment.
The indentation here seems to be too big
|
Hi all, I can prepare a French translation for the properties... Regards, |
The-Lum
added a commit
to The-Lum/keystore-explorer
that referenced
this pull request
Apr 8, 2024
To follow: - kaikramer#486 - kaikramer#487 Here is a commit in order to adding/updating the French Resources for Fingerprint functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.