Add K0s utility functions and cleanup #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 53.11% 52.50% -0.62%
==========================================
Files 19 19
Lines 1973 1996 +23
==========================================
Hits 1048 1048
- Misses 795 818 +23
Partials 130 130 ☔ View full report in Codecov by Sentry. |
jimmykarily
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks for your work on this @wrkode!
I haven't seen the provider code yet so I would suggest we wait before we merge this until we see how it's used (in case the provider implementation shows that there is a better option than what we have here).
|
relates to kairos-io/kairos#3121 |
2 tasks
mauromorales
approved these changes
Jan 14, 2025
Signed-off-by: William Rizzo <[email protected]>
Signed-off-by: William Rizzo <[email protected]>
Signed-off-by: William Rizzo <[email protected]>
see kairos-io/kairos#3126 Signed-off-by: Mauro Morales <[email protected]>
This function is not specific for k3s hence also not for k0s Signed-off-by: Mauro Morales <[email protected]>
For versioning we now use the versioneer package also in this repo. I couldn't find any instance of components depending on utils.Version() so I think it's safe to remove Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
This reverts commit c5f48d9.
This is not being used anymore, use Versioneer package instead Signed-off-by: Mauro Morales <[email protected]>
Co-authored-by: Dimitris Karakasilis <[email protected]>
Itxaka
approved these changes
Jan 14, 2025
mauromorales
added a commit
to kairos-io/provider-kairos
that referenced
this pull request
Jan 14, 2025
This PR is dependent of kairos-io/kairos-sdk#546, and it adds the possibility to deploy k0s instead of k3s. refactored `oneTimeBootstrap()` to handle k0s and k3s. Added `K0s` type to bootstrap `config` package added k0s to provider `package`` InteractiveInstall()` and check for mutual exclusivity CC: @mauromorales --------- Signed-off-by: William Rizzo <[email protected]> Signed-off-by: Mauro Morales <[email protected]> Co-authored-by: Mauro Morales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the systemd units and Env needed for provider-kairos to be able to manage k0s deployments.
I'm working on the provider-kairos as well.
UtilsPackageK0sBin()added function for k0s binaryVersion()Updated to handle both K3s and K0s versionsWriteEnv()Made generic to handle any service environmentFindCommandEnhanced to dynamically search for k0sGetInit()Improved readability and robustnessPowerOFF()Updated to use a more generic shutdown commandmachinepackageadded k0s services functions
CC @mauromorales