Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerization and Small Adjustments #5

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Dockerization and Small Adjustments #5

merged 18 commits into from
Feb 2, 2024

Conversation

l4rm4nd
Copy link
Contributor

@l4rm4nd l4rm4nd commented Feb 2, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our contribution guidelines
  • This change does not contain any possible security vulnerabilities

What kind of change does this PR introduce?

  • Containerize the application stack with Docker. Simplify the process of self-hosting.
  • Add tel: hyperlink to the restaurant's phone number and a hyperlink to Google Maps for the restaurant's location.
  • Adjust the readme to reflect the additions regarding Docker

What is the current behavior?

Application stack must be installed manually, barebone. Separate MariaDB database required too.

What is the new behavior?

Application stack can be spawned up using Docker Compose.

Does this PR introduce a breaking change?

The code adjustments and new files should not break existing instances when being updated.

Other things to mention?

You'll have to adjust the Docker image defined in the docker-compose.yml file if you want to provide an externally hosted Docker Image (e.g. from Dockerhub). Currently, my Docker Image is still referenced for testing purposes.

Currently, the npm build process is postponed to the Docker runtime, as the application code relies on production ready environment variables (especially NEXT_PUBLIC_IMAGEKIT_URL_ENDPOINT). I'll try some other methods to get an optimized production build ready during Docker Image build process. In the meantime, user just have to wait a few minutes until the docker container comes up, as the build process takes some time.

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kaje94 kaje94 merged commit 5251c50 into kaje94:main Feb 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants