Replace stack network type with network ID #85
+14
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-r
reviewed
Feb 6, 2025
| Optional: true, | ||
| Computed: true, | ||
| "network_id": &schema.StringAttribute{ | ||
| Required: true, |
There was a problem hiding this comment.
Not sure if this should be required. I believe it only is for chain infrastructure stacks
dan-r
reviewed
Feb 6, 2025
| @@ -44,7 +44,7 @@ type StacksAPIModel struct { | |||
| EnvironmentMemberID string `json:"environmentMemberId,omitempty"` | |||
| Name string `json:"name"` | |||
| Type string `json:"type"` | |||
| NetworkType string `json:"networkType,omitempty"` | |||
There was a problem hiding this comment.
And if its made optional, this needs to remain omitempty
dan-r
reviewed
Feb 6, 2025
| } | ||
| } | ||
|
|
||
| func (api *StacksAPIModel) toData(data *StacksResourceModel) { | ||
| data.ID = types.StringValue(api.ID) | ||
| data.EnvironmentMemberID = types.StringValue(api.EnvironmentMemberID) | ||
| data.NetworkType = types.StringValue(api.NetworkType) | ||
| data.NetworkId = types.StringValue(api.NetworkId) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.