Always change language where necessary if path changes

[deanc]

A fix for this issue:
#1

[kalinchernev]

What's the idea in mind of adding i18n in the dependencies list for the side effect?

[deanc]

Ah, the latest builds of gatsby use eslint which gives this warning:

warn ESLintError:
/Users/dc/Projects/finbb-frontpage/src/layouts/index.js
  16:6  warning  React Hook useEffect has missing dependencies: 'i18n' and 'locale'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

After a bit of research the recommendation is that you should include all dependencies that are inside the useEffect hook inside that second array, as they can change from the outside too, which in theory should change how they are used inside the hook.

[kalinchernev]

Alright, thanks, that's cool :)
I personally don't like putting whole objects in a dep list, but if the linter say so :P

[deanc]

Sure, but think of it this way. It's used inside the hook, so it is a dependency.

[kalinchernev]

It's no worries, for the example here it's good. In actual project some checks whether its necessary to make the change of language will be easy to make

…

On Fri, 13 Dec 2019, 12:58 Dean Clatworthy, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/layouts/index.js <#3 (comment)>: > import withI18next from "../i18n/withI18next"; -const Layout = ({ children }) => { +const Layout = ({ children, location, pageContext: { locale }}) => { + + const { i18n } = useTranslation() + + useEffect(() => { + i18n.changeLanguage(locale) + }, [location, i18n, locale]) Sure, but think of it this way. It's used inside the hook, so it is a dependency. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AAOVTFCRFRTIH22EUBDTNHTQYN2IBA5CNFSM4J2DC4IKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPDURAY#discussion_r357613450>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOVTFCCCR2JNGTT6DCZJN3QYN2IBANCNFSM4J2DC4IA> .