Set limit on list results #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sispheor
reviewed
Nov 24, 2018
| | sentences | no | 10 | Integer in range 1-10 | if set, return the first number of sentences(can be no greater than 10) specified in this parameter. | | ||
| | titles | no | ~ | Integer | With this parameter you can limit the number of search result in case there are more then one | |
There was a problem hiding this comment.
maybe titles is not the right name for this parameter
There was a problem hiding this comment.
According to wikipedia.summary those are auto_suggest.
So, what about auto_suggest or auto_suggest_limit ?
Sispheor
reviewed
Nov 24, 2018
| @@ -39,7 +40,7 @@ def __init__(self, **kwargs): | |||
| # The options property contains a list of titles of Wikipedia pages that the query may refer to. | |||
| self.may_refer = e.options | |||
| # Removing duplicates in lists. | |||
| self.may_refer = list(set(self.may_refer)) | |||
| self.may_refer = list(set(self.may_refer))[:self.titles] | |||
There was a problem hiding this comment.
it defaults to None thanks to line 23 self.titles = kwargs.get('titles', None) and serves back all the results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way searches with many results like "me" can be limited in order to avoid a long and boring long message.