-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmulder/key auth value #33
Conversation
Odd, I see these:
All the tests pass though. Maybe these should be going to debug, not error? |
Otherwise, LGTM. Thanks for doing this! I built this against some test code and it worked as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When you merge, can you issue a release? |
@dmulder released 0.2.0 |
Sigh, I always forget about the dependency loop on compact-jwt. That also needs to be updated to point to the new hsm-crypto (else none of my code will build). |
If all goes well, I will push my changes to compact-jwt today so we can release them. |
Refers #32 - Fix PIN Value support for identity keys. This works on the TPM with it's native lockout features, and soft with argon2id derivation hmaced (peppered) to the machine key.
Checklist