Skip to content

Commit

Permalink
Use case insensitive read-only (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
yuzhouliu9 authored Jul 20, 2022
1 parent 3c89d50 commit 4a674ee
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ All kubernetes runtime types have the following in common. They embed [ObjectMet
- Given a type with ObjectMeta
- generate a Constructor that accepts the name of the resources
- generate DeepCopy and DeepCopyInto wrappers of the parent type
- generate members of ObjectMeta not tagged as `// Read-only`
- generate members of ObjectMeta not tagged as `// Read-only` (case insensitive)

- Given a type with Builtin / Primitive members
- generate setter functions for each member not tagged as `// Read-only`.
- generate setter functions for each member not tagged as `// Read-only` (case insensitive).
9 changes: 8 additions & 1 deletion pkg/generators/builder/member_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,19 @@ func TestIncludeMember(t *testing.T) {
want: true,
},
{
description: "should not include Read-only member",
description: "should not include member labeled Read-only",
dir: "c/meta",
typeSelector: "ObjectMeta",
member: "ReadOnlyMember",
want: false,
},
{
description: "should not include member labeled read-only (lowercase)",
dir: "c/meta",
typeSelector: "ObjectMeta",
member: "ReadOnlyLowerCase",
want: false,
},
}

for _, test := range tests {
Expand Down
2 changes: 2 additions & 0 deletions pkg/generators/builder/testdata/c/meta/meta.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ type ObjectMeta struct {
IntPtr *int
// Read-only.
ReadOnlyMember *string
// Bla bla read-only
ReadOnlyLowerCase int
}
2 changes: 1 addition & 1 deletion pkg/generators/tags/tags.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func IsTypeOptedOut(t *types.Type) bool {

func IsMemberReadyOnly(m types.Member) bool {
for _, s := range m.CommentLines {
if strings.Contains(s, "Read-only") {
if strings.Contains(strings.ToLower(s), "read-only") {
return true
}
}
Expand Down

0 comments on commit 4a674ee

Please sign in to comment.