Add thumbnail.save configuration option. #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this option is set to False, then do not save newly-generated thumbnails to the disk. Previously saved thumbnail images will be used normally and will never be deleted. This saves space and reduces drive writes at the cost of extra computational overhead by making the original image be reopened each time the thumbnail is loaded.
karlch
requested changes
Jul 11, 2023
|
Looks like one of the tests timed out at |
karlch
approved these changes
Jul 11, 2023
|
Yes, unfortunately the runner is extremely slow from time to time (one can see that actually all tests progress a lot slower). I have absolutely no clue why, this only happens on CI, haven't had any issues locally. Noted a while ago in #335. EDIT: re-ran the workflow, works as expected, this is my go-to super annoying workaround until any idea why this happens ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #651 changes. Also, the
check_thumbails_createdintests/unit/utils/test_thumbnail_manager.pymight be a typo. Figured this should probably be another pull request or quick commit from maintainers, though.If this option is set to False, then do not save newly-generated thumbnails to the disk. Previously saved thumbnail images will be used normally and will never be deleted.
This saves space and reduces drive writes at the cost of extra computational overhead by making the original image be reopened each time the thumbnail is loaded.