Added Words #23
Open
Added Words #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the CharSplitLMMinibatchLoader to words where words are continuous strings of letters or any non-letter symbol.
ghost
mentioned this pull request
|
Finished and working with no bugs found. Ready for merging. |
|
Tests here appear to be causing trouble, I'm not sure why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can now treat words as tokens in addition to chars using the
-wordscommand line option. For some reason this uses a huge amount of ram proportional to the size of the vocabulary. I was not able to run it on tinyshakespeare but instead had to run it on the first 150K of tinyshakespeare. A words is defined a sequence of consecutive letters or any one non-letter symbol. The way I did this may not always be pretty (although I think it is reasonably nice) as this was the first lua programming I have ever done.