fix typo in string matching

Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12 · Jan 7, 2025 · 24420b4 · 24420b4
1 parent 1e4030d
commit 24420b4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/...-management/src/main/java/org/opensearch/plugin/wlm/rule/structure/RuleAttributeTrie.java b/...-management/src/main/java/org/opensearch/plugin/wlm/rule/structure/RuleAttributeTrie.java
@@ -38,7 +38,7 @@ public void insert(String key, String value) {
     }
 
     private boolean isValidValue(String value) {
-        return ALLOWED_ATTRIBUTE_VALUES.matches(value);
+        return value.matches(ALLOWED_ATTRIBUTE_VALUES);
     }
 
     /**

diff --git a/.../test/java/org/opensearch/plugin/wlm/rule/structure/FastPrefixMatchingStructureTests.java b/.../test/java/org/opensearch/plugin/wlm/rule/structure/FastPrefixMatchingStructureTests.java
@@ -157,11 +157,6 @@ public void testInsertAndSearchEmptyString() {
             assertEquals(Collections.singletonList("empty"), trie.search(""));
         }
 
-        @Test
-        public void testInsertEmptyValue() {
-            trie.insert("emptyvalue", "");
-            assertEquals(Collections.singletonList(""), trie.search("emptyvalue"));
-        }
 
         @Test
         public void testDeleteEmptyString() {
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,7 +38,7 @@ public void insert(String key, String value) { @@
         }
         private boolean isValidValue(String value) {
-            return ALLOWED_ATTRIBUTE_VALUES.matches(value);
+            return value.matches(ALLOWED_ATTRIBUTE_VALUES);
         }
         /**
@@ Expand Down @@