Merge branch 'main' into chore/optimize-components-build

kawa-fe · Feb 1, 2025 · 3c1efba · 3c1efba
2 parents f05e9e6 + 397a760
commit 3c1efba
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/docs/components/_meta.json b/docs/components/_meta.json
@@ -1 +1 @@
-["index", "image", "list", "resume_header"]
+["index", "image", "list", "resume_header"]
diff --git a/packages/components/image/Image.tsx b/packages/components/image/Image.tsx
@@ -3,8 +3,7 @@ import type { ImageProps } from './Image.types';
 
 const Image = React.memo(
   forwardRef<HTMLImageElement, ImageProps>((props: ImageProps, ref) => {
-    const { src, alt, width, height, style, onClick, className, userData } =
-      props;
+    const { src, alt, width, height, style, className, userData } = props;
 
     return (
       <img
@@ -14,7 +13,6 @@ const Image = React.memo(
         width={width}
         height={height}
         style={style}
-        onClick={onClick}
         className={className}
       />
     );

diff --git a/packages/components/list/list.tsx b/packages/components/list/list.tsx
@@ -9,16 +9,14 @@ const List = memo(
         data,
         renderItem = (item: T) => <div>{String(item)}</div>,
       }: ListProps<T>,
-      ref: React.ForwardedRef<HTMLDivElement>,
+      ref: React.ForwardedRef<HTMLUListElement>,
     ) => {
       return (
-        <div ref={ref} role="list">
+        <ul ref={ref}>
           {data.map((item, index) => (
-            <div key={index} role="listitem">
-              {renderItem(item, index)}
-            </div>
+            <li key={crypto.randomUUID()}>{renderItem(item, index)}</li>
           ))}
-        </div>
+        </ul>
       );
     },
   ),

diff --git a/packages/components/package.json b/packages/components/package.json
@@ -37,4 +37,4 @@
       "types": "./dist/index.d.ts"
     }
   }
-}
+}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		["index", "image", "list", "resume_header"]
		["index", "image", "list", "resume_header"]
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,4 +37,4 @@ @@
           "types": "./dist/index.d.ts"
         }
       }
-    }
+    }