Skip to content

Commit

Permalink
remove pests
Browse files Browse the repository at this point in the history
  • Loading branch information
kayasax committed Mar 18, 2024
1 parent 0d51d38 commit c429e06
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions EasyPIM/functions/Get-PIMGroupActiveAssignment.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
EntraID tenant ID
.PARAMETER groupID
The group id to check
.PARAMETER memberType
.PARAMETER memberType
Filter results by memberType (owner or member)
.PARAMETER principalName
Filter results by principalName starting with the given value
.Parameter summary
When enabled will return the most useful information only
.Example
PS> Get-PIMGroupActiveAssignment -tenantID $tid -groupID $gID
PS> Get-PIMGroupActiveAssignment -tenantID $tid -groupID $gID
List active assignement for the group $gID
.Example
Expand Down
2 changes: 1 addition & 1 deletion EasyPIM/internal/functions/Import-Settings.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function Import-Setting ($path) {
"Recipients" = $_.Notification_Activation_Approver_Recipients.split(',')
}
$rules += Set-Notification_Activation_Approver $Notification_Activation_Approver
#>
#>
# patch the policy
Update-Policy $_.policyID $($rules -join ',')
}
Expand Down
4 changes: 2 additions & 2 deletions EasyPIM/internal/functions/Set-Approval.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function Set-Approval ($ApprovalRequired, $Approvers, [switch]$entraRole) {
],
"escalationApprovers":[]
}]}}]}
#>
#>

$rule = '{
"id":"Approval_EndUser_Assignment",
Expand Down Expand Up @@ -93,7 +93,7 @@ function Set-Approval ($ApprovalRequired, $Approvers, [switch]$entraRole) {
"escalationApprovers":[]
}]
}
}'
}'


<# $rule = '
Expand Down
5 changes: 2 additions & 3 deletions EasyPIM/internal/functions/Set-ApprovalFromCSV.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ if ($ApprovalRequired -eq "FALSE") { $req = "false" }else { $req = "true" }
# turn approvers list to an array
$Approvers= $Approvers -replace "^","@("
$Approvers= $Approvers -replace "$",")"
write-verbose "APPROVERS: $Approvers"
#write-verbose "APPROVERS: $Approvers"
#then turn the sting into an array of hash table

$Appr = Invoke-Expression $Approvers
$Appr = Invoke-Expression $Approvers

$rule += '
"primaryApprovers": [
Expand All @@ -73,7 +73,6 @@ if ($ApprovalRequired -eq "FALSE") { $req = "false" }else { $req = "true" }
$id = $_.id
$name = $_.description
$type = $_.userType
write-host "ID => $($_.id)"

if ($cpt -gt 0) {
$rule += ","
Expand Down

0 comments on commit c429e06

Please sign in to comment.