Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for for issue #5 #6

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Fix for for issue #5 #6

merged 4 commits into from
Mar 18, 2024

Conversation

justin-p
Copy link
Contributor

Fix for for issue #5

@kazauwa
Copy link
Owner

kazauwa commented Mar 15, 2024

Hi!
Thank you so much for reporting this bug and finding time to fix it!
All these changes look good to me. However, could you replace ansible.builtin.meta and ansible.builtin.systemd_service with meta and systemd_service, respectively?

The reason is that FQCNs may break compatibility with Ansible 2.9. I want to release this fix as a patch version since this bug prevents the first installation from running successfully.

That said, this role deserves some love, and I owe it an upgrade to support modern Ansible versions. However, it'd be a breaking change that deserves a major version bump.

@justin-p
Copy link
Contributor Author

Hia @kazauwa,

No problem my dude. It takes less time to fix this role then build it from scratch myself ;) Reverted those changes back to non-FQCN.

@kazauwa
Copy link
Owner

kazauwa commented Mar 18, 2024

Thank you very much!

@kazauwa kazauwa merged commit e039324 into kazauwa:main Mar 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Reload handler fails because previous restart handler is still restarting the service
2 participants