Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defensive programming has been added to api 'GetEntries()' to reduce NPE #238

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix: defensive programming has been added to api 'GetEntries()' to reduce NPE #238

merged 1 commit into from
Dec 25, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #228

2. What is the scope of this PR (e.g. component or file name):

Defensive programming has been added to api 'GetEntries()' to reduce NPE

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Dec 25, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy December 25, 2023 07:39
@zong-zhe zong-zhe self-assigned this Dec 25, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7320132587

  • 1 of 4 (25.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 39.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/package/modfile.go 0 1 0.0%
pkg/package/package.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/package/package.go 1 39.84%
Totals Coverage Status
Change from base Build 7319653945: 0.1%
Covered Lines: 1495
Relevant Lines: 3753

💛 - Coveralls

@zong-zhe zong-zhe marked this pull request as ready for review December 25, 2023 07:42
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 7aa8c2c into kcl-lang:main Dec 25, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Bug] Nil pointer for local package run Enhancement: kpm add command displaying optimization
3 participants