Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add prowjobs #2

Merged
merged 3 commits into from
Jan 10, 2025
Merged

✨ add prowjobs #2

merged 3 commits into from
Jan 10, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jan 9, 2025 •
edited
Loading

This adds some basic Prowjobs to check PRs before merging.

NONE

@xrstf xrstf closed this Jan 9, 2025
@xrstf xrstf reopened this Jan 9, 2025
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Jan 9, 2025

/retest

@xrstf xrstf changed the title add prowjobs ✨ add prowjobs Jan 9, 2025
@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 9, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Jan 9, 2025

/retest

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@xrstf xrstf force-pushed the add-prow branch 3 times, most recently from 46ecb40 to fda5871 Compare January 9, 2025 18:42
@xrstf xrstf requested a review from embik January 9, 2025 18:54
embik
embik approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d6e5148db6ca2f8428a253b6bc5071215e35543

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@embik
Copy link
Member

embik commented Jan 10, 2025

/hold

for kcp-dev/infra#84.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Jan 10, 2025

/unhold

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@kcp-ci-bot kcp-ci-bot merged commit 55ff2dc into main Jan 10, 2025
10 checks passed
@kcp-ci-bot kcp-ci-bot deleted the add-prow branch January 10, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kcp-ci-bot @embik