-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): Release 0.5.0 #473
Conversation
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: L. R. Couto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
…ro-plugins into release/kedro-docker/0.5.0
Somehow the logs are wrapped in a more narrow max width now and that's why some assertions fail. For example one test expects
(notice how the line is broken) https://github.com/kedro-org/kedro-plugins/actions/runs/7186100161/job/19570771296?pr=473#step:7:168 |
Might be helpful: https://stackoverflow.com/questions/14446861/matching-discontinuous-interrupted-strings |
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
I starting to suspect if this PR accidentally bring in a bug #92, I am not certain because before that our e2e-test never try to write on mounted storage. The problem only appear when using with the |
I propose we do the following:
It would be a shame to have the compatibility with Kedro 0.19.0 blocked by this issue which might have been broken for a much longer time already. |
@merelcht After reading this carefully, I have changed my mind and I don't think it is a broken feature, it is just a bad test.
I agree with this. The permission problem is not a bug because UID/GID need to match with the host. For someone who set this manually should be aware of the consequence. I propose we update the test. Instead of testing with a pipeline run, we can use |
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! Great work fixing it ⭐
I would suggest doing the release in a separate PR though, to make it easier to trace back the different changes. The release PR should ideally just be the version bump + release notes.
Signed-off-by: lrcouto <[email protected]>
Description
Release
kedro-docker
0.5.0Development notes
Checklist
RELEASE.md
file