Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.0 #168

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Release 0.3.0 #168

merged 6 commits into from
Feb 5, 2025

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Feb 4, 2025

This pull request includes updates to the Kedro VSCode Extension, with changes to the changelog, version number, and dependencies. The most important changes include adding new features, updating the version, and modifying the requirements for testing.

Major changes and new features:

#162: Support settings of custom project path in Kedro Extension.
#163: Enable primary tool bar with toolbarOptions.
#159: Validate dataset classes in catalog using LSP.
#164: Remove the old dependencies with yaml schema.

Version update:

  • Updated the version from 0.2.3 to 0.3.0 in package.json.

Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 self-assigned this Feb 4, 2025
requirements.txt Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
4. Manually test if the artifact works (no automated tests yet)
5. Manually upload to VSCode Marketplace and VSX Registry (Drag and Drop)

To upload a release, you will need to be added as a contributor or owner for both VSCode Marketplace and VSX Registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope we can automate this soon #128

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#128 will only fix the problem partially. I have not explored if there is a way to release on VSX through a CLI / API yet.

The heavy work here is the manual testing part (i.e. trigger a click on flowchart etc), not so much on the Github Action.

@jitu5 jitu5 requested review from noklam and astrojuanlu February 4, 2025 18:44
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!!

@rashidakanchwala
Copy link

i tested #162, #163, and #159. With regards to #163, do we want to keep the open/close sidebar icon or should we hide it. it feels a bit messy in the embedded state @astrojuanlu , @jitu5

@astrojuanlu
Copy link
Member

Thanks @rashidakanchwala , let's release!

Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments. It may be helpful to also highlight the "Problem" Page since this is new. This can show all the problem at once instead of moving the cursor around.

image ^The screenshot is not the correct one as for some reason I cannot find the page, but I remember seeing this before.

In additional, do we want to add some mention to this in Kedro's doc? We only have a page for [Setup VSCode], but maybe this is something we want to highlight.

@astrojuanlu
Copy link
Member

In additional, do we want to add some mention to this in Kedro's doc?

Yep indeed, an update to our docs is due. I'll open an issue about it.

@jitu5
Copy link
Contributor Author

jitu5 commented Feb 5, 2025

It may be helpful to also highlight the "Problem" Page since this is new. This can show all the problem at once instead of moving the cursor around.

@noklam Sorry I did not get it completely, where we need to highlight ? are you suggesting to make this changes in this PR ?

@noklam
Copy link
Contributor

noklam commented Feb 5, 2025

@jitu5 I mean the README as I saw the GIF is replaced.

image

^ok it's actually on the same page so I guess there is no change on the "Problem Page", for some reason I thought it's a new tab.

@jitu5 jitu5 merged commit c4cde3d into main Feb 5, 2025
2 checks passed
@jitu5 jitu5 deleted the 0.3.0 branch February 5, 2025 11:18
@jitu5 jitu5 restored the 0.3.0 branch February 5, 2025 11:19
@astrojuanlu astrojuanlu deleted the 0.3.0 branch February 5, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants