Implement timer for tBTC Rewards interval #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented timer on tBTC Rewards page that shows when the next rewards will be released.
r-czajkowski
requested changes
Dec 14, 2020
| setRemainingMinutes(minutes - 1) | ||
| } else if (remainingMinutes === 0) { | ||
| setRemainingMinutes(59) | ||
| if (remainingHours > 0) { |
There was a problem hiding this comment.
nested ifs... 🤯 out of idea now how we can do better, but let's keep 👀 on that.
There was a problem hiding this comment.
One way to get cleaner code would be to keep the remainingSeconds only and then when displaying we could format it with moment js. However, I don't think it will be efficient to do such thing every re-render (which means every sec). Thoughts?
There was a problem hiding this comment.
However, I don't think it will be efficient to do such thing every re-render (which means every sec)
Agree. Let's keep it in mind, maybe someday we'll do it better 😆
Change Timer component props so it uses timestamp in units instead of days, hours, minutes and seconds.
Refactor Timer component to make sure targetInUnix prop is indeed a timestamp in unix instead of a moment object as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a timer on the tBTC Rewards page that shows when the next rewards will be released.