This repository has been archived by the owner on May 22, 2023. It is now read-only.
ETH Delegating #483
Merged
ETH Delegating #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkkuba should this be against |
pdyraga
reviewed
Aug 10, 2020
pdyraga
reviewed
Aug 11, 2020
nkuba
force-pushed
the
abstract-bonding
branch
4 times, most recently
from
aa0503f to
0befc5c
Compare
nkuba
force-pushed
the
eth-bonding
branch
4 times, most recently
from
f94a068 to
af542f4
Compare
pdyraga
reviewed
Aug 19, 2020
nkuba
force-pushed
the
eth-bonding
branch
3 times, most recently
from
a89b18a to
491dbc7
Compare
pdyraga
reviewed
Oct 30, 2020
pdyraga
reviewed
Oct 30, 2020
pdyraga
reviewed
Oct 30, 2020
pdyraga
reviewed
Oct 30, 2020
pdyraga
reviewed
Oct 30, 2020
pdyraga
reviewed
Oct 30, 2020
We defined a `topUp` function in `FullyBackedBonding` contract. This function should be used when adding new value for bonding. We emitt an additional event to clearly find value that has been deposited. The `deposit` function defined in the abstract contract can be used also by applications that return part of seized value to the contract. This made calculation of totally deposited value much more difficult.
pdyraga
reviewed
Nov 2, 2020
pdyraga
reviewed
Nov 2, 2020
pdyraga
reviewed
Nov 2, 2020
pdyraga
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ETH Delegating that will be integrated into ECDSA Keeps.
ETHDelegatingcontract is a very basic draft of the contract that will evolve as we integrate it with Keep Factory. We need delegation details like:beneficiaryandauthorizerfor the givenoperator. The idea is that the owner will calldelegatefunction providing these details so they can be later used for bonding.TODO:
Refs: #271
Depends on keep-network/keep-core#1873
Depends on #525
Depends on keep-network/sortition-pools#89