Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more tests passing #282

Merged
merged 11 commits into from
Nov 18, 2024
Merged

fix: more tests passing #282

merged 11 commits into from
Nov 18, 2024

Conversation

SoarinSkySagar
Copy link
Contributor

@SoarinSkySagar SoarinSkySagar commented Nov 13, 2024 •
edited
Loading

New tests passing:

  • SIG_HIGH_S:
["0x48 0x304502203e4516da7253cf068effec6b95c41221c0cf3a8e6ccb8cbf1725b562e9afde2c022100ab1e3da73d67e32045a20e0b999e049978ea8d6ee5480d485fcf2ce0d03b2ef001","0x21 0x03363d90d447b00c9c99ceac05b6262ee053441c7e55552ffe526bad8f83ff4640 CHECKSIG","LOW_S","SIG_HIGH_S","P2PK with high S"]
  • DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM:
[["304402205ae57ae0534c05ca9981c8a6cdf353b505eaacb7375f96681a2d1a4ba6f02f84022056248e68643b7d8ce7c7d128c9f1f348bcab8be15d094ad5cadd24251a28df8001","0479be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798483ada7726a3c4655da4fbfc0e1108a8fd17b448a68554199c47d08ffb10d4b8",0E-8],"","1 0x14 0x91b24bf9f5288532960ac687abb035127b1d28a5","DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM,P2SH,WITNESS","DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM","P2WPKH with future witness version"],

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024

@SoarinSkySagar is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@SoarinSkySagar SoarinSkySagar marked this pull request as ready for review November 15, 2024 08:09
@SoarinSkySagar
Copy link
Contributor Author

gm @b-j-roberts, fixed 2 more tests, please review

dlaciport
dlaciport reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dlaciport dlaciport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments. otherwise LGTM!

packages/engine/src/flags.cairo Show resolved Hide resolved
packages/utils/src/byte_array.cairo Outdated Show resolved Hide resolved
@SoarinSkySagar
Copy link
Contributor Author

@bloomingpeach made the required changes now

@dlaciport
Copy link
Contributor

LGTM, thank you @SoarinSkySagar

@SoarinSkySagar
Copy link
Contributor Author

LGTM, thank you @SoarinSkySagar

cool, now just waiting for @b-j-roberts to merge the PR

b-j-roberts
b-j-roberts approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@b-j-roberts b-j-roberts merged commit 739a292 into keep-starknet-strange:main Nov 18, 2024
3 of 4 checks passed
@SoarinSkySagar SoarinSkySagar deleted the error_2 branch November 19, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaciport dlaciport dlaciport left review comments

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoarinSkySagar @dlaciport @b-j-roberts