Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): funkit integration #95

Merged
merged 10 commits into from
Jul 3, 2024
Merged

feat(backend): funkit integration #95

merged 10 commits into from
Jul 3, 2024

Conversation

chloe-tan
Copy link
Contributor

@chloe-tan chloe-tan commented Jun 26, 2024 •
edited
Loading

StarkNet <> Fun.xyz Integration

starknetxfun

Changelog

  1. Add new endpoints to Vault's backend to interface with Fun.xyz's checkout protocol. Full endpoint information can be found in the documentation link below
  2. Add new environment variable FUNKIT_API_KEY
  3. Add "big.js": "^6.2.1" into dependencies and "@types/big.js": "^6.2.2" into devDependecies

Documentation

https://the-fun-group.notion.site/StarkNet-Stripe-Fun-xyz-Integration-Guide-3badde91c07b4bd98ad99eb3c5f5a295?pvs=74

TODOs

  1. Get help from core team to add FUNKIT_API_KEY to backend prod/staging environment

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 9:29pm

@chloe-tan chloe-tan marked this pull request as draft June 26, 2024 01:38
chloe-tan
chloe-tan commented Jun 26, 2024
View reviewed changes
backend/pnpm-lock.yaml Outdated Show resolved Hide resolved
@chloe-tan chloe-tan changed the title [wip] feat: funkit integration [wip] feat(backend): funkit integration Jun 26, 2024
@chloe-tan
Copy link
Contributor Author

What is the process for running and adding tests? Running pnpm run test locally gives me errors

image

@chloe-tan chloe-tan marked this pull request as ready for review June 26, 2024 19:33
@chloe-tan chloe-tan changed the title [wip] feat(backend): funkit integration feat(backend): funkit integration Jun 26, 2024
0xLucqs
0xLucqs requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good but could you add some tests plz (at least for the failing paths)

backend/src/routes/funkit.ts Outdated Show resolved Hide resolved
backend/package.json Show resolved Hide resolved
backend/src/routes/funkit.ts Outdated Show resolved Hide resolved
@chloe-tan
Copy link
Contributor Author

@LucasLvy @0xChqrles

Added test files for all 3 routes 6cc77fd.

Running locally, they are all passing:

image

0xChqrles
0xChqrles approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xChqrles 0xChqrles merged commit 866e29c into keep-starknet-strange:main Jul 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xLucqs 0xLucqs 0xLucqs requested changes

@0xChqrles 0xChqrles 0xChqrles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chloe-tan @0xChqrles @0xLucqs