Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show database public icon on tab when visible #11725

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

droidmonkey
Copy link
Member

Adds the public icon (if set) to the database tab when it is visible.

Screenshots

Visible when locked
image

and unlocked
image

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link
Member

@varjolintu varjolintu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. The only small thing I noticed is that when the unlock screen has an icon visible, the "Unlock KeePassXC database" text jumps a little bit. But this is a very minor thing in the layout.

@droidmonkey
Copy link
Member Author

droidmonkey commented Feb 9, 2025

@varjolintu Not sure what you mean by your comment, can you elaborate?

@droidmonkey droidmonkey force-pushed the fix/icon-in-tab branch 2 times, most recently from b7138d0 to 6264c0e Compare February 9, 2025 20:08
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (c9a64be) to head (1b54901).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/DatabaseTabWidget.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11725      +/-   ##
===========================================
+ Coverage    63.57%   63.58%   +0.01%     
===========================================
  Files          367      367              
  Lines        38810    38819       +9     
===========================================
+ Hits         24673    24681       +8     
- Misses       14137    14138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varjolintu
Copy link
Member

@varjolintu Not sure what you mean by your comment, can you elaborate?

Screen.Recording.2025-02-09.at.22.48.02.mp4

@droidmonkey
Copy link
Member Author

Ah I see, I tried putting the icon at the end when I first developed this and it didn't look right. We can play around with some more options in later releases if it is bothersome to people.

@droidmonkey droidmonkey merged commit 51e8c04 into develop Feb 10, 2025
11 checks passed
@droidmonkey droidmonkey deleted the fix/icon-in-tab branch February 10, 2025 01:02
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Feb 11, 2025
droidmonkey added a commit that referenced this pull request Feb 11, 2025
* Show database public icon on tab when visible

* Remove unnecessary assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backported Pull request backported to previous release user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants