-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show database public icon on tab when visible #11725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. The only small thing I noticed is that when the unlock screen has an icon visible, the "Unlock KeePassXC database" text jumps a little bit. But this is a very minor thing in the layout.
@varjolintu Not sure what you mean by your comment, can you elaborate? |
b7138d0
to
6264c0e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11725 +/- ##
===========================================
+ Coverage 63.57% 63.58% +0.01%
===========================================
Files 367 367
Lines 38810 38819 +9
===========================================
+ Hits 24673 24681 +8
- Misses 14137 14138 +1 ☔ View full report in Codecov by Sentry. |
Screen.Recording.2025-02-09.at.22.48.02.mp4 |
Ah I see, I tried putting the icon at the end when I first developed this and it didn't look right. We can play around with some more options in later releases if it is bothersome to people. |
6264c0e
to
1b54901
Compare
* Show database public icon on tab when visible * Remove unnecessary assert
Adds the public icon (if set) to the database tab when it is visible.
Screenshots
Visible when locked
![image](https://private-user-images.githubusercontent.com/2809491/408878684-c9f835b7-440d-4e8d-92af-ccaa82e8049d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjU3MjYsIm5iZiI6MTczOTUyNTQyNiwicGF0aCI6Ii8yODA5NDkxLzQwODg3ODY4NC1jOWY4MzViNy00NDBkLTRlOGQtOTJhZi1jY2FhODJlODA0OWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDkzMDI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmM4MzE5NzBmODNiYzI3YjYyMjc5OTZkYmJlMWVjMTc5YjJlMGIyNjFlYThmOGQ3MDFhOTQzYWJmMjQxZjQzYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.pWcnXODl3RjLAEqL0vx3TuRBRJVSzP3pHFWUPJ0aIVI)
and unlocked
![image](https://private-user-images.githubusercontent.com/2809491/408878700-e27a6ad7-b1ed-44bc-a51d-1937285121e8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjU3MjYsIm5iZiI6MTczOTUyNTQyNiwicGF0aCI6Ii8yODA5NDkxLzQwODg3ODcwMC1lMjdhNmFkNy1iMWVkLTQ0YmMtYTUxZC0xOTM3Mjg1MTIxZTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDkzMDI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2RkYzQ5Mzc3YTI0MDRhYjAwYWVjZmM3ZjM3MDZlMWI3MDliY2JmYmUyNzZmNmE2MWY5MjA1NDM3Njg0MWYxMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.gYW7WIVPUd-A55DJrlixUR2jP-MPSZshosOAmMocJuo)
Type of change