-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Cognitive Services voices support #177
base: firefox
Are you sure you want to change the base?
Conversation
Great work, thank you. However, there's a problem with Firefox. If you check the FF branch, there's no aws-sdk.js. I had to remove it because Mozilla rejects minified third-party code. I'll have to prove where I get the code from, has to be an official source, and how to build it, etc. Basically they make it real difficult. I'm thinking about creating a separate branch for this. This feature won't be used by most regular users. Only more advanced users, i.e. developers who know how to set up Azure account, will use it. In that case they can clone the branch and install manually. Also it will keep the size of the package small. |
#168 actually has different intention, to call the web API on that demo page and provide these voices for free, to the extent Microsoft would allow it. Would have to try it out first, may not work. |
That's unfortunate :/ Actually this article says they banned obfuscated code, but still accept third party libraries (minified or not). But there might be more scrutiny indeed. The extension policies also rule out loading remote code for execution, which would have solved the size issue.
That can work, but I'd recommend using a single branch and some feature flags that can include or exclude files/features when packaging, as it would be easier to maintain.
Ack. I suppose it can work: there's a 5h tts free tier, which should be ok for a demo page (if using a subscription key for public demo is fine). |
Yes, let me do a little more thinking, let's keep this open as work in progress |
Support for Microsoft Azure Cognitive Services voices -
closes #168. [WIP]Questions: