Form block: Allow dynamic JSON schema input to schemaGetter without sub-flow, avoiding reactivity issues #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukestanley
commented
Feb 20, 2025
lukestanley
commented
- JMESPath mapping string resolved with context.
- Flexible, tolerant parsing of different input types, if no jsonSchema key is found, treats the result as the schema.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodeKrakken
requested changes
Feb 20, 2025
| } else { | ||
| this.fields = []; | ||
| // To make it easier for the user, we are flexible with the input of schemaGetter: | ||
| // If we get the schemaGetter has a string, we assume it is a JMESPath mapping we need to resolve with context. |
There was a problem hiding this comment.
Typo - should "has" be "as"?
| const contextInjectedJsonSchema = this.injectContextToJsonSchema(plainJsonSchema); | ||
| this.fields = this.formService.schemasToFieldConfig(contextInjectedJsonSchema, get(result, 'uiSchema', {})); | ||
| } else { | ||
| // if a JMESPath string is not provided, we except a sub-workflow is defined |
There was a problem hiding this comment.
Typo - should "except" be "expect"?
…ub-flow, avoiding reactivity issues - JMESPath mapping string resolved with context. - Flexible, tolerant parsing of different input types, if no jsonSchema key is found, treats the result as the schema.
lukestanley
force-pushed
the
form-block-direct-json-schema-getter
branch
from
0e5c830 to
b1b846a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.