Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect changes made in 2ce8884 #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Whenever the original PEP 8 at python.org gets updated we need to migrate these

To migrate the latest changes from the original PEP 8 source do the following:

* Look at the [source control history for the original PEP 8](https://github.com/python/peps/commits/master/pep-0008.txt) and compare it with what's live on pep8.org. (As of 2019-06 we're tracking rev `2f8f1ec`.)
* Look at the [source control history for the original PEP 8](https://github.com/python/peps/commits/master/pep-0008.txt) and compare it with what's live on pep8.org. (As of 2019-09 we're tracking rev `2ce8884`.)

* Apply the missing changes to `index.html` and create a pull-request to get them reviewed and live on pep8.org

Expand Down
9 changes: 9 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -1220,6 +1220,15 @@ <h1 id="programming-recommendations">Programming Recommendations</h1>
<p class="no">Worse:</p>
<pre><code class="language-python">if greeting is True:</code></pre></li>

<li><p>Use of the flow control statements <code>return</code>/<code>break</code>/<code>continue</code> within the finally suite of a <code>try...finally</code>, where the flow control statement would jump outside the finally suite, is discouraged. This is because such statements will implicitly cancel any active exception that is propagating through the finally suite.</p>
<p class="no"><span>No:</span></p>
<pre><code class="language-python">def foo():
try:
1 / 0
finally:
return 42
</code></pre></li>

</ul>


Expand Down