Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes samples-go linter errors #128

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

NishantBansal2003
Copy link
Contributor

Fixes: keploy/keploy#2514

PR Description:

  • Fixed Linter Errors: Resolved all linter issues across the samples-go subdirectories.
  • Version Bumps:
    • Updated Go to the latest stable version.
    • Bumped golangci-lint to the latest version for improved linting.
  • Configuration Update: Removed only-new-issues: true to ensure that new PRs will now detect and fix all linting errors.

Signed-off-by: Nishant Bansal <[email protected]>
@NishantBansal2003
Copy link
Contributor Author

NishantBansal2003 commented Jan 23, 2025

PTAL @khareyash05 @shivamsouravjha

Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the log fatal as it os.exit

Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
@NishantBansal2003
Copy link
Contributor Author

NishantBansal2003 commented Jan 26, 2025

Please remove the log fatal as it os.exit

I tried fixing it in some places; however, in some cases, log.Fatal is required because the error prevents the program from proceeding.
PTAL

Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamsouravjha shivamsouravjha merged commit 06db96d into keploy:main Jan 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: samples-go to fix linter errors
2 participants