-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build for multi-architecture amd/arm #1165
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # .github/workflows/ci-build-manual-crf.yml
I'm getting
when trying to run on macos m1 |
@heijligers which image did you try? This one was correctly built with multi arch and arm support: My next step was to try to solve this issue with spawning process by looking on a way to have a conditional decision in the Dockerfile Any help is welcome for this issue 🙂 |
I am currently working on this for the default CRF Docker (Docker.crf) . This needs work :-
There seems a number of libraries involved :-
tinihttps://github.com/krallin/tini pdfaltohttps://github.com/kermitt2/pdfalto libwapitihttps://github.com/kermitt2/wapiti libcrfpphttps://github.com/taku910/crfpp/ libjephttps://github.com/ninia/jep I will update this comment as a tracking comment as I make progress. |
@lfoppiano It seems the way to deal with multi platform and multi architecture OS/ARCH builds is with build and buildx :-
https://github.com/docker/buildx?tab=readme-ov-file#building-multi-platform-images This should work across multiple docker images :- |
Finally I nailed it!
This PR provide a multi-architecture build for amd64/arm64. I've switched to the eclipse-adoptium-17-jdk/jre but, for the moment, I'm using ubuntu 20.04 (focal) instead of ubuntu 22. For now Is limited to the manual build for the CRF only image.
This requires some tests,
herehere the resulting image.This PR should help to solve #1089 and #928