Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify install instructions #73

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Simplify install instructions #73

merged 1 commit into from
Apr 24, 2024

Conversation

timbmg
Copy link
Contributor

@timbmg timbmg commented Apr 12, 2024

The library can be directly installed from github with pip. No need to clone it first.

@lfoppiano lfoppiano merged commit 6835e55 into kermitt2:master Apr 24, 2024
@kermitt2
Copy link
Owner

Hello! I've completed a bit the install documentation, as one might prefer to use the latest PyPI version, or to have the complete source (useful to have config.json or example.py on hand given that they are referenced in the readme). So the user can choose.

@lfoppiano
Copy link
Collaborator

I though that for the installation it was equivalent. Personally I either use the client from the source, or install it as dependency. Never do both 😅

If I may 😅, I would then propose to install with pip -e . rather than using python setup.py install, as it's more standardized and will work with other project descriptors (e.g. pyproject.toml, as proposed in PR #77).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants