cloud: Fix .pgpass and password deployment

cloud

@@ -125,7 +125,6 @@ function execute_command() {
     declare -r updated_topic="${prefix}updated"
     declare -r updated_debug_subscription="${prefix}updated_debug"
     declare -r spool_collection_path="${prefix}notifications"
-    declare -r smtp_password_secret="kcidb_smtp_password"
 
     declare -r psql_connection=$(
         echo -n "${project}:"

kcidb/cloud/password.sh

@@ -220,7 +220,7 @@ function password_deploy_secret() {
             # Get and cache the password in the current shell first
             password_get "$name" > /dev/null
             # Deploy the cached password
-            password_get "$name" | secret_deploy "$project" "$name"
+            password_get "$name" | secret_deploy "$project" "$secret"
         fi
     done
 }
@@ -261,15 +261,27 @@ function password_deploy_pgpass_secret() {
         password_names+=("$1")
         shift 2
     done
+    declare new_pgpass
     declare exists
+
+    # Generate the (potentially) new pgpass with cached passwords
+    new_pgpass="$(password_get_pgpass "${password_and_user_names[@]}")"
+
+    # If the secret already exists
     exists=$(secret_exists "$project" "$pgpass_secret")
-    if ! "$exists" || password_is_specified "${password_names[@]}"; then
-        # Cache the passwords in the current shell
-        password_get_pgpass "${password_and_user_names[@]}" > /dev/null
-        # Generate and deploy the .pgpass
-        password_get_pgpass "${password_and_user_names[@]}" |
-            secret_deploy "$project" "$pgpass_secret"
+    if "$exists"; then
+        declare old_pgpass
+        # Retrieve the current pgpass
+        old_pgpass="$(secret_get "$project" "$pgpass_secret")"
+        # If the pgpass hasn't changed
+        if [ "$new_pgpass" == "$old_pgpass" ]; then
+            # Don't deploy
+            return
+        fi
     fi
+
+    # Deploy the .pgpass
+    secret_deploy "$project" "$pgpass_secret" <<<"$new_pgpass"
 }
 
 fi # _PASSWORD_SH

kcidb/cloud/psql.sh

@@ -89,6 +89,7 @@ function psql_instance_deploy() {
             --region="$PSQL_INSTANCE_REGION" \
             --tier="$PSQL_INSTANCE_TIER" \
             --assign-ip \
+            --no-storage-auto-increase \
             --database-flags=cloudsql.iam_authentication=on \
             --root-password="$(password_get psql_superuser)" \
             --database-version=POSTGRES_14