Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/submitter_guide: replace block diagram with png #587

Merged

Conversation

tales-aparecida
Copy link

The "block-beta" diagram used was introduced in mermaid v10.8, and we're not there yet in our documentation deployment.

The PNG added by this commit has meta data that allows it to be edited as a diagram using tools like draw.io, also known as diagrams.net.

Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Tales! Looks good, except could you please fix the spelling of responsibility in the image's file name?

responsible), "run test" leads to "DONE" (no result needed), "ERROR" (test
not completed, test maintainer responsible), then "evaluate result" leads to
"PASS" (requirements met) or "FAIL" (requirements failed, kernel developer
responsible).](mapping-test-status-and-responsability.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have this spell responsability (and so the image doesn't show at all) 🙈

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry

The "block-beta" diagram used was introduced in mermaid v10.8, and we're
not there yet in our documentation deployment.

The PNG added by this commit has meta data that allows it to be edited
as a diagram using tools like draw.io, also known as diagrams.net.

Signed-off-by: Tales da Aparecida <[email protected]>
@spbnick
Copy link
Collaborator

spbnick commented Oct 8, 2024

Thank you, Tales ❤️

@spbnick spbnick merged commit f0f1c76 into kernelci:main Oct 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants