Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.main: perform authorization for GET '/user/<id>' #431

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

JenySadadia
Copy link
Collaborator

Only allow authorized users to get user details matching given user ID to protect user's personal information.

Only allow authorized users to get user details
matching given user ID to protect user's personal
information.

Signed-off-by: Jeny Sadadia <[email protected]>
@gctucker
Copy link
Contributor

Looks like the client-side changes in kernelci-core got merged too early as they depend on this?

@nuclearcat
Copy link
Member

There was patches related to /users endpoint, they are merged, and follow-up on similar issue, this and kernelci/kernelci-core#2239 (not merged), another, /user/ endpoint.

@nuclearcat
Copy link
Member

Tested on staging with kernelci/kernelci-core#2239

Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuclearcat nuclearcat added this pull request to the merge queue Dec 13, 2023
Merged via the queue into kernelci:main with commit b436db4 Dec 13, 2023
4 checks passed
@JenySadadia JenySadadia deleted the get-user-by-id-authorization branch December 13, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants