Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.email_sender: catch SMTP related exceptions #443

Merged
merged 1 commit into from
Dec 28, 2023
Merged

api.email_sender: catch SMTP related exceptions #443

merged 1 commit into from
Dec 28, 2023

Conversation

JenySadadia
Copy link
Collaborator

Add try-catch block to EmailSender._send_email method to catch exception while sending emails.

api.email_sender: catch SMTP related exception
2c35a42 
Add `try-catch` block to `EmailSender._send_email` method
to catch exception while sending emails.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia JenySadadia mentioned this pull request Dec 28, 2023
Closed
nuclearcat
nuclearcat approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully on next issue it will help us to catch errors, meanwhile all works fine on staging

@nuclearcat nuclearcat added this pull request to the merge queue Dec 28, 2023
Merged via the queue into kernelci:main with commit d494208 Dec 28, 2023
4 checks passed
@JenySadadia JenySadadia deleted the catch-email-error branch December 28, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearcat nuclearcat nuclearcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JenySadadia @nuclearcat