Bug fix: admin users with duplicate email #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
approved these changes
Jan 9, 2024
|
It looks like it need rebase now? |
The script is allowing multiple users with the same email address. Fix the issue by creating unique DB index on `User.email` field. Remove manual check for existing `username`. Catch `DuplicateKeyError` from `pymongo` while creating users for duplicate username or email field. Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
fix-duplicate-email
branch
from
4da71e1 to
7100c03
Compare
|
@nuclearcat Could you please update email of |
|
Done, but i set non-existing email for admin. I guess it's ok for now, for staging |
Yes, it will work for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444
Created on top of #436
Staging has multiple users with the same email address. Fix the bug in admin user setup script.