-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted e2e test updates #453
Conversation
r-c-n
commented
Jan 10, 2024
•
edited
Loading
edited
- Fix pipeline test (sync it to Node model changes)
- The "test" service of test-docker-compose.yaml no longer launches the tests on startup. Update the run_e2e_tests.sh script to start the service and run the tests.
- Fix inconsistencies in pytest dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing locally:
WARNING: Cannot resolve the dependency marker 'e2e_tests/test_user_creation.py::test_create_regular_user' - ignoring it.
WARNING: Cannot resolve the dependency marker 'e2e_tests/test_subscribe_handler.py::test_subscribe_node_channel' - ignoring it.
WARNING: Cannot resolve the dependency marker 'e2e_tests/test_subscribe_handler.py::test_subscribe_test_channel' - ignoring it.
One solution is to mount
Another solution is to update all the dependecy markers to use
I think the first one looks easier than updating all the tests. |
4002678
to
265c44a
Compare
Signed-off-by: Ricardo Cañuelo <[email protected]>
Signed-off-by: Ricardo Cañuelo <[email protected]>
265c44a
to
68b6d69
Compare
The first solution didn't work, but I don't understand why. pytest only raises these warnings for some dependency headers but not for others, totally inconsistent. I ended up fixing all the dependency paths, that's the only thing that worked. I also added a fix for the pipeline test (model-related) that I didn't catch earlier because that test was being skipped. |
Signed-off-by: Ricardo Cañuelo <[email protected]>
68b6d69
to
d5a30e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK.