-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernelci.api: refactor user-facing API models #2249
Conversation
Bring the API models used by the user-facing endpoints from the kernelci-api repo to this one so that they can be used by the kernelci-api code and the helpers in this repo. Bring the base model definitions here as well into a separate file (models_base.py) so that they can be used by the models here and by the internal kernelci-api models. Signed-off-by: Ricardo Cañuelo <[email protected]>
6afabe2
to
8a2b28b
Compare
@JenySadadia gentle ping for this. Approved? |
Did we get staging results along with kernelci/kernelci-api#433 yet? If yes, what did you do about |
I dropped the
We're stuck in 1. I think this can be merged. About 2, I have no idea. @nuclearcat have you updated the kernelci pip package before? |
I'd rather suggest waiting for the staging results along with dependent API PR. This will enable us to find and fix any issues with this one before merging. |
8a2b28b
to
c7e7b8b
Compare
I don't know if we're talking about the same thing but I think we're going in circles now. AFAIK we can't test this in staging along with the related API PR because the API PR depends on this being merged to be tested. The API changes depend on this PR but this PR doesn't depend on the API changes, so this one should go first, and after it's merged we'll be able to test the API PR on staging. Does that make sense? |
c7e7b8b
to
2aa905f
Compare
@JenySadadia ok, so the related kernelci-api PR passed the tests when sync'd to this PR: https://github.com/kernelci/kernelci-api/actions/runs/7447272775, https://github.com/kernelci/kernelci-api/actions/runs/7447272771. We can merge this now, then remove the staging-skip tag of the other PR and wait for it to run on staging |
Could you please resolve the comment about pinning |
Signed-off-by: Ricardo Cañuelo <[email protected]>
Signed-off-by: Ricardo Cañuelo <[email protected]>
2aa905f
to
c5dc0ba
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Change node update according to new model: kernelci#2249 Signed-off-by: Denys Fedoryshchenko <[email protected]>
Change node update according to new model: #2249 Signed-off-by: Denys Fedoryshchenko <[email protected]>
Related to kernelci/kernelci-api#433 (that PR depends on this one)
Bring the API models used by the user-facing endpoints from the kernelci-api repo to this one so that they can be used by the kernelci-api code and the helpers in this repo.
Bring the base model definitions here as well into a separate file (models_base.py) so that they can be used by the models here and by the internal kernelci-api models.