Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/plugins index page #2240

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Feat/plugins index page #2240

merged 7 commits into from
Feb 19, 2025
+655 −557

Conversation

brian-mulier-p
Copy link
Member

@brian-mulier-p brian-mulier-p commented Feb 17, 2025 •
edited
Loading

closes #1926

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2025 •
edited
Loading

Deploying kestra-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: e97664e
Status: ✅  Deploy successful!
Preview URL: https://834e59e7.kestra-io.pages.dev
Branch Preview URL: https://feat-plugins-index-page.kestra-io.pages.dev

View logs

@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-index-page branch from 5adf9db to 7ed0bb4 Compare February 17, 2025 17:38
@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-index-page branch 5 times, most recently from fe79638 to 66b333e Compare February 18, 2025 00:39
elevatebart
elevatebart requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
Almost there a few remarks.

@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-index-page branch from 66b333e to 8dc2039 Compare February 18, 2025 15:01
elevatebart
elevatebart approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIth the caveat of capitalize this looks rather good indeed.
LGTM!

@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-index-page branch from 8dc2039 to 3d53a9f Compare February 19, 2025 11:51
@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-index-page branch from 3d53a9f to e97664e Compare February 19, 2025 12:05
@brian-mulier-p brian-mulier-p merged commit da41a15 into main Feb 19, 2025
1 check passed
@brian-mulier-p brian-mulier-p deleted the feat/plugins-index-page branch February 19, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevatebart elevatebart elevatebart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an improved design of main Plugin pages
2 participants
@brian-mulier-p @elevatebart