fix(core): handle NoClassDefFoundError in PluginScanner

kestra-io · Jun 21, 2024 · 80db45c · 80db45c
1 parent bd5d5c5
commit 80db45c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/core/src/main/java/io/kestra/core/plugins/PluginScanner.java b/core/src/main/java/io/kestra/core/plugins/PluginScanner.java
@@ -106,9 +106,9 @@ private RegisteredPlugin scanClassLoader(final ClassLoader classLoader,
 
         final ServiceLoader<Plugin> sl = ServiceLoader.load(Plugin.class, classLoader);
         try {
-            sl.forEach(plugin -> {
+            for (Plugin plugin : sl) {
                 if (plugin.getClass().isAnnotationPresent(Hidden.class)) {
-                    return;
+                    continue;
                 }
 
                 switch (plugin) {
@@ -141,10 +141,14 @@ private RegisteredPlugin scanClassLoader(final ClassLoader classLoader,
                 }
 
                 Plugin.getAliases(plugin.getClass()).forEach(alias -> aliases.put(alias, plugin.getClass()));
-            });
-        } catch (ServiceConfigurationError e) {
+            }
+        } catch (ServiceConfigurationError | NoClassDefFoundError e) {
             Object location = externalPlugin != null ? externalPlugin.getLocation() : "core";
-            log.error("Unable to load all plugin classes from '{}'. Cause: {}", location, e.getMessage());
+            log.error("Unable to load all plugin classes from '{}'. Cause: [{}] {}",
+                location,
+                e.getClass().getSimpleName(),
+                e.getMessage()
+            );
         }
 
         var guidesDirectory = classLoader.getResource("doc/guides");