Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jdbc): be resilient to DataException #7408

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

loicmathieu
Copy link
Member

We usually fail fast, but when a DataException is thrown it means the JDBC driver throws an exception with error code 22: data exception. As the exception is from the data not the database or the network, there is no point of failfast, we throw a QueueException that may or may not be handled gracefully by the call site.

Fixes #7221

We usually fail fast, but when a DataException is thrown it means the JDBC driver throws an exception with error code 22: data exception.
As the exception is from the data not the database or the network, there is no point of failfast, we throw a QueueException that may or may not be handled gracefully by the call site.
Copy link

codecov bot commented Feb 14, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1457 2 1455 5
View the top 2 failed test(s) by shortest run time
io.kestra.runner.h2.H2ServiceLivenessCoordinatorTest taskResubmitSkipExecution()
Stack Traces | 2.06s run time
java.lang.AssertionError: 
Expected: is <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at io.kestra.jdbc.runner.JdbcServiceLivenessCoordinatorTest.taskResubmitSkipExecution(JdbcServiceLivenessCoordinatorTest.java:161)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
io.kestra.plugin.core.execution.ExitTest shouldExitAndKillTheExecution()
Stack Traces | 30s run time
java.util.concurrent.TimeoutException: Await failed to terminate within PT30S.
	at io.kestra.core.utils.Await.until(Await.java:42)
	at io.kestra.core.utils.Await.until(Await.java:31)
	at io.kestra.core.runners.RunnerUtils.awaitExecution(RunnerUtils.java:161)
	at io.kestra.core.runners.RunnerUtils.runOneUntilRunning(RunnerUtils.java:140)
	at io.kestra.core.runners.RunnerUtils.runOneUntilRunning(RunnerUtils.java:124)
	at io.kestra.plugin.core.execution.ExitTest.shouldExitAndKillTheExecution(ExitTest.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

Worker container crashes when python task passes outputs with unicode escape sequences
1 participant