Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sendgrid): Sendgrid Email notification returns errors but task marked as succeeded #179

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mgabelle
Copy link
Contributor

fix api

throw exception if status code is not 2xx

#178

@mgabelle
Copy link
Contributor Author

mgabelle commented Nov 13, 2024

Adding link to Sendgrid v3 API for more context about this change.
Now the client must set the from field in the Mail object and not in the Personalization object.

…rked as succeeded

fix api

throw exception if status code is not 2xx

update test

#178
@mgabelle mgabelle force-pushed the fix/sendgrid-errors-marked-as-success branch from b50b0f1 to 3bcfdfc Compare November 13, 2024 10:15
@mgabelle mgabelle merged commit 2606b0e into master Nov 13, 2024
1 check passed
@mgabelle mgabelle deleted the fix/sendgrid-errors-marked-as-success branch November 13, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant