Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: duplicate variable initialization #61

Merged
merged 1 commit into from
Dec 26, 2023
Merged

remove: duplicate variable initialization #61

merged 1 commit into from
Dec 26, 2023

Conversation

juroberttyb
Copy link
Contributor

Var of type int64 is default to 0 if not given init value.

@juroberttyb
remove: duplicate variable initialization
32de426 
Var of type int64 is default to 0 if not given init value.
@kevinanielsen kevinanielsen added docs Improvements or additions to documentation api Improvements or additions to the api go Language: Go labels Dec 26, 2023
@juroberttyb juroberttyb mentioned this pull request Dec 26, 2023
Closed
@kevinanielsen
Copy link
Owner

Thanks for the contribution! :)

Everything looks perfect - If I had to mention one thing, this would probably be a commit type of refactor, so if you had to do it again, maybe give the commit a message of refactor: remove duplicate variable initialization But honestly, that's just nitpicking and this is a great PR :)

@kevinanielsen kevinanielsen merged commit 555b06f into kevinanielsen:main Dec 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinanielsen kevinanielsen kevinanielsen approved these changes

Assignees
No one assigned
Labels
api Improvements or additions to the api docs Improvements or additions to documentation go Language: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juroberttyb @kevinanielsen