Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few Words removed and edited in the dictionary. #302

Closed
wants to merge 5 commits into from

Conversation

quwatsunny
Copy link
Contributor

Kindly update the model.

@keyman-server
Copy link

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Collaborator

There are changes to two different (though related) lexical models in this pull request. It's generally easier if each PR has changes to just one model. You should consider creating a branch for each pull request, which would allow you to work on two models at the same time.

It seems that the burushos.bsk-latn.burushaski.model.kps file has been deleted. That file needs to be restored.

In order for any changes to be effective, the version number needs to change in the .kps file, otherwise the build system won't build the model (since it thinks it already has the latest version). In addition to changing the .kps file, please note the version number change and the reason for the update in the HISTORY.md file.

The burushos.bsk-latn.burushaski.model.ts has a line with a doubled comma:
sources: ['wordlist.tsv'],,
The second comma should be deleted.

Since the year is now 2025, please change the LICENSE.md file for the burushos.bsk.burushaski model to use 2023-2025 in the Copyright statement.

Thanks!

@quwatsunny quwatsunny closed this by deleting the head repository Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants