Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latin Dictionary has been improved #305

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

quwatsunny
Copy link
Contributor

Hello David,

As per your advice, I have make changes to the files. I hope this one is ok to be merged.

Just update the lice year and version
The dictionary has been updated for improvement. Individual characters as dictionary words have been removed.
@keyman-server
Copy link

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Collaborator

@quwatsunny The changes to the bsk-Latn files look good. Unfortunately, this pull request seems to have picked up other changes that belong to the bsk lexicial model. This is easy to do when you work in your "master" branch.

I've reverted the two bsk files, so this should be good to merge.

Copy link
Collaborator

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (after reverting files from a different lexical model)

@DavidLRowe DavidLRowe merged commit 6703cdf into keymanapp:master Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants