Skip to content

Commit

Permalink
fix failing unit tests (#10348)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidjumani authored Nov 14, 2024
1 parent 733a90f commit 0fe3e5a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/pr-unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ name: Unit Tests
#
# Our historical unit tests are run via CloudBuild
# Overtime, it would be valuable to consolidate these approaches
env:
VERSION: '1.0.0-ci1'
GITHUB_TOKEN: ${{ github.token }}

on:
pull_request:
Expand Down
4 changes: 2 additions & 2 deletions test/kubernetes/testutils/helper/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ func TestReturnsLatestPatchForMinor(t *testing.T) {
ctx := context.Background()
// this is fine because this is a public repo
client := githubutils.GetClientWithOrWithoutToken(ctx)
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 8)
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 9)
require.NoError(t, err)

assert.Equal(t, "v1.8.37", minor.String())
assert.Equal(t, "v1.9.30", minor.String())
}

0 comments on commit 0fe3e5a

Please sign in to comment.