Adds EP-10411: Gateway API Inference Extension Support #10420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehans
added
Type: Docs
Area: Gloo Plugin
Area: Extensibility
Area: K8S Gateway API
|
cc: @EItanya |
EItanya
reviewed
Jan 13, 2025
npolshakova
reviewed
Jan 14, 2025
npolshakova
reviewed
Jan 14, 2025
stevenctl
added a commit
to stevenctl/gloo
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Daneyon Hansen <[email protected]> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Daneyon Hansen <[email protected]> Co-authored-by: Yuval Kohavi <[email protected]> Co-authored-by: Sam Heilbron <[email protected]> Co-authored-by: Nathan Fudenberg <[email protected]> Co-authored-by: Ryan Old <[email protected]> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Bernie Birnbaum <[email protected]> Co-authored-by: Rachael Graham <[email protected]> Co-authored-by: Ravinder Punia <[email protected]> Co-authored-by: sheidkamp <[email protected]> Co-authored-by: Jenny Shu <[email protected]> Co-authored-by: Nadine Spies <[email protected]> Co-authored-by: David Jumani <[email protected]> Co-authored-by: Eitan Yarmush <[email protected]> Co-authored-by: Nina Polshakova <[email protected]> Co-authored-by: Steven Landow <[email protected]> Co-authored-by: Ariana W. <[email protected]>
npolshakova
approved these changes
Jan 23, 2025
linsun
reviewed
Jan 28, 2025
linsun
reviewed
Jan 28, 2025
linsun
reviewed
Jan 28, 2025
linsun
reviewed
Jan 28, 2025
linsun
reviewed
Jan 28, 2025
linsun
reviewed
Jan 28, 2025
docs/enhancements/10411.md
Outdated
| ### Configuration | ||
|
|
||
| * Update the [configuration](https://github.com/k8sgateway/k8sgateway/blob/main/install/helm/gloo/generate/values.go) API to enable/disable this feature. | ||
| * Update Helm charts to install/uninstall k8sgateway with this feature based on user-provided configuration. |
There was a problem hiding this comment.
If this is enabled via GatewayParameters, does it require helm charts change? Trying to understand if this is configured at install time of CP or deployment of the gateway DP?
There was a problem hiding this comment.
A user should be able to set a Helm knob to enable this feature. The internal config plumbing should convert the helm know into the equivalent GatewayParameters setting. This will avoid users having to configure the GatewayParameters for GIE during runtime. Depending on the time required to implement this EP, I may defer the Helm piece as follow-up work.
There was a problem hiding this comment.
SGTM thanks for the explanation!
Adds Enhancement Proposal 10411 that proposes adding Gateway API Inference Extension support. Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
linsun
approved these changes
Jan 30, 2025
|
@danehans Just a heads up that we moved the enhancements repository outside of the docs/ directory into https://github.com/kgateway-dev/kgateway/tree/main/design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Enhancement Proposal 10411 that proposes adding Gateway API Inference Extension support.
Supports #10411