group gateway.gloo.solo.io -> gateway.kgateway.dev #10544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshu
reviewed
Jan 29, 2025
| @@ -7,9 +7,9 @@ metadata: | |||
| labels: | |||
| app: gloo-gateway | |||
| app.kubernetes.io/name: gloo-gateway | |||
| name: directresponses.gateway.gloo.solo.io | |||
| name: directresponses.gateway.kgateway.dev | |||
There was a problem hiding this comment.
general question - do we still need the gateway or can we just shorten it to directresponses.kgateway.dev?
There was a problem hiding this comment.
good question - I did that as looking at other projects (like istio) it seems common to have x. format where X is a "theme" (security,traffic, etc..). that's said, there's a chance that given our scope our only "theme" will be gateway. so not sure
jenshu
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the group of our CRDs
also added basic yaml tests for upstream and route options to prove out the change