projects/gw2: Move examples to root directory #10579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]>
4 tasks
jenshu
reviewed
Feb 5, 2025
There was a problem hiding this comment.
does it make sense to just remove the examples directory and rely on the unit / e2e tests as examples? in theory the tests should cover (most of) the use cases we support
maybe we could merge this PR for now to unblock the refactor, then if needed, remove as part of the test cleanup (after we verify they are actually covered by existing tests)?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the project/gateway2/examples to the root directory. Related to #10566.
Checklist: