feat: request and response transformation #10595
Draft
+214
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfuden
reviewed
Feb 10, 2025
| @@ -122,6 +264,15 @@ func (p *routeOptsPluginGwPass) ApplyForRouteBackend( | |||
| // if a plugin emits new filters, they must be with a plugin unique name. | |||
| // any filter returned from route config must be disabled, so it doesnt impact other routes. | |||
| func (p *routeOptsPluginGwPass) HttpFilters(ctx context.Context, fcc ir.FilterChainCommon) ([]plugins.StagedHttpFilter, error) { | |||
|
|
|||
| if p.needFilter { | |||
There was a problem hiding this comment.
Should we add this to plugin signature?
There was a problem hiding this comment.
not sure i understand the ask?
stevenctl
pushed a commit
to stevenctl/gloo
that referenced
this pull request
Feb 12, 2025
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Nathan Fudenberg <[email protected]> Co-authored-by: Sam Heilbron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.