Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying #68

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Tidying #68

merged 4 commits into from
Jun 9, 2024

Conversation

kgaughan
Copy link
Owner

@kgaughan kgaughan commented Jun 9, 2024

Summary by Sourcery

This pull request refactors the error handling in the TempFile function to use inline error checks and removes unused dependencies from the go.mod file.

  • Enhancements:
    • Refactored error handling in TempFile function to use inline error checks.
  • Chores:
    • Removed unused dependencies from go.mod file.

Copy link

sourcery-ai bot commented Jun 9, 2024

Reviewer's Guide by Sourcery

This pull request focuses on tidying up the code by refactoring error handling in the TempFile function and removing unused dependencies from the go.mod file.

File-Level Changes

Files Changes
internal/testutils/testutils.go Refactored error handling to make the code more concise and readable.
go.mod Cleaned up the go.mod file by removing unused dependencies.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgaughan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

internal/testutils/testutils.go Show resolved Hide resolved
internal/testutils/testutils.go Show resolved Hide resolved
internal/testutils/testutils.go Show resolved Hide resolved
kgaughan and others added 2 commits June 9, 2024 16:30
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@kgaughan kgaughan merged commit e5593c9 into master Jun 9, 2024
4 checks passed
@kgaughan kgaughan deleted the tidying branch June 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant