Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade toolchain and dependencies where possible #119

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kgaughan
Copy link
Owner

@kgaughan kgaughan commented Dec 17, 2024

Summary by Sourcery

Upgrade various dependencies in requirements.txt and go.mod to their latest versions, including Go toolchain and CI linting action.

Build:

  • Upgrade Go toolchain to version 1.23.2 in go.mod.

CI:

  • Update golangci-lint-action to version v1.61.0 in the GitHub Actions workflow.

Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This pull request updates various dependencies and toolchain versions across the project. The changes include upgrading the Go toolchain from 1.22.3 to 1.23.2, updating Python package versions in requirements.txt, and upgrading the golangci-lint version in the GitHub Actions workflow.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgrade Go toolchain and version requirements
  • Update Go version from 1.21 to 1.23
  • Upgrade toolchain from go1.22.3 to go1.23.2
go.mod
Update Go dependencies
  • Upgrade Masterminds/semver/v3 from v3.3.0 to v3.3.1
  • Upgrade PuerkitoBio/goquery from v1.9.3 to v1.10.0
go.mod
go.sum
Update Python package dependencies
  • Upgrade mkdocs-material from 9.5.36 to 9.5.49
  • Upgrade markupsafe from 2.1.5 to 3.0.2
  • Upgrade watchdog from 5.0.2 to 6.0.0
  • Upgrade wcmatch from 9.0 to 10.0
  • Update various minor version bumps for other dependencies
requirements.txt
Update CI tooling
  • Upgrade golangci-lint-action from v1.59.1 to v1.61.0
.github/workflows/lint.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgaughan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief summary in the PR description explaining the motivation for these updates (e.g., security fixes, new features needed, routine maintenance)
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kgaughan kgaughan merged commit fa7f793 into master Dec 17, 2024
4 checks passed
@kgaughan kgaughan deleted the upgrade-toolchain branch December 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant